Integrate pyformat with localize() #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@mediaminister @michaelarnauts @pietje666 I wanted your feedback on this implementation, but since I require it for #385 I am going to merge it now. And we can improve/fix/change this as needed. |
By integrating string formattig with the localize() function call we can make both the translations easier to comprehend, as well as the code more transparant/readable. And by using SafeDict() it is also more reliable if arguments do not add up. When a key is not found the 'template' remains in the string.
dagwieers
force-pushed
the
localize_format
branch
from
85d6c48 to
9deafe9
Compare
Contributor
|
I like this verry much. It's actually needed to translate to other languages since you don't know the order of the words. |
Collaborator
|
I am all in favor for more readable code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By integrating string formattig with the localize() function call we can
make both the translations easier to comprehend, as well as the code
more transparant/readable.
And by using SafeDict() it is also more reliable if arguments do not add up.
When a key is not found the 'template' remains in the string.